This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Optimize TpuConnection and its implementations #23877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
previously approved these changes
Mar 23, 2022
| @@ -63,19 +63,22 @@ impl TpuConnection for QuicTpuConnection { | |||
| &self.client.addr | |||
| } | |||
|
|
|||
| fn send_wire_transaction(&self, wire_transaction: &[u8]) -> TransportResult<()> { | |||
| fn send_wire_transaction<T>(&self, wire_transaction: T) -> TransportResult<()> | |||
There was a problem hiding this comment.
ideally these API changes would be at least a separate commit. given that neither they, nor the switch to enums build off each other, a separate PR is also appropriate.
I know I'm being a pain in the ass about this, but making the smallest, most concise, change per PR drastically improves reviewability (and review turnaround!) and also allows for higher resolution reverts should that need to happen
| @@ -121,6 +184,13 @@ mod tests { | |||
| addr_str.parse().expect("Invalid address") | |||
| } | |||
|
|
|||
| fn ip(conn: Connection) -> IpAddr { | |||
There was a problem hiding this comment.
could be on impl Connection { (still under mod test) instead of standalone
…n-cache to not use dyn in order to enable those changes
ryleung-solana
force-pushed
the
tpu-connection-optimize
branch
from
9ecaca8 to
510c1ca
Compare
mergify
bot
dismissed stale reviews from t-nelson and lijunwangs
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
…n-cache to not use dyn in order to enable those changes (#23877) (cherry picked from commit 82945ba) # Conflicts: # client/Cargo.toml # client/src/quic_client.rs # client/src/thin_client.rs # client/src/tpu_connection.rs # client/src/udp_client.rs # core/src/voting_service.rs # send-transaction-service/src/send_transaction_service.rs
t-nelson
pushed a commit
to t-nelson/solana
that referenced
this pull request
Mar 25, 2022
…n-cache to not use dyn in order to enable those changes (solana-labs#23877)
t-nelson
pushed a commit
that referenced
this pull request
Mar 25, 2022
…n-cache to not use dyn in order to enable those changes (#23877)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and refactor connection-cache to not use dyn in order to enable those changes
Problem
See #23817 - this PR pulls out the parts of it that optimize TpuConnection to use AsRef as well as the enabling refactoring to connection-cache to allow these changes to be made (i.e. not using dyn).
Summary of Changes
Fixes #