This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Move BloomHashIndex into its own module #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait is for bloom, not crds. Slightly better would be to put it in the SDK so that the trait implementations could go into hash and pubkey, but if we don't want compatibility constraints, this is the next best thing.
garious
requested review from
aeyakovenko
and removed request for
aeyakovenko
|
@aeyakovenko, added you as a reviewer, but then removed you - assuming this is noncontroversial. |
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
========================================
- Coverage 74.4% 71.7% -2.7%
========================================
Files 110 110
Lines 17150 17790 +640
========================================
+ Hits 12761 12762 +1
- Misses 4389 5028 +639 |
tao-stones
added a commit
to tao-stones/solana
that referenced
this pull request
Aug 1, 2024
…na-cost-model to its own crate. (solana-labs#2378) refactor: move statically defined builtin default costs map from solana-cost-model to its own crate. Makes sharing builtin costs between crates easier, and provide space to future refactoring; Issue solana-labs#2351
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Awkward name
cdrs_traits_impl.rsSummary of Changes
Rename the module and yoink the trait definition.
Slightly better would be to put it in the SDK so that the trait
implementations could go into hash and pubkey, but if we don't
want compatibility constraints, this is the next best thing.