This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rename AccountsDb plugins to Geyser plugins #23604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing due to toml sort changes just merged, but passed CI previously |
CriesofCarrots
force-pushed
the
geyser
branch
2 times, most recently
from
1fb3504 to
626f8ec
Compare
lijunwangs
reviewed
Mar 11, 2022
lijunwangs
reviewed
Mar 11, 2022
lijunwangs
reviewed
Mar 11, 2022
lijunwangs
reviewed
Mar 11, 2022
CriesofCarrots
force-pushed
the
geyser
branch
2 times, most recently
from
0c294a6 to
0bf8aea
Compare
t-nelson
previously approved these changes
Mar 12, 2022
There was a problem hiding this comment.
Changes here lgtm! The rollout is the main open question.
Tyera and I discussed at lunch and it seems least intrusive if we can release the last version of the solana-accountsdb-plugin-interface and the first version of the solana-geyser-plugin-interface with an otherwise unchanged API/ABI/behavior set. So the steps are basically...
- land imminent additions to
solana-accountsdb-plugin-interface - publish crate (in-band?)
- merge this PR
- publish crate (out-of-band?)
- (opt?) publish a final out-of-band
solana-accountsdb-plugin-interfacecrate with all public symbols marked deprecated
how does this sound to you @lijunwangs?
mergify
bot
dismissed stale reviews from t-nelson and lijunwangs
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
(cherry picked from commit 102dd68) # Conflicts: # Cargo.lock # Cargo.toml # core/Cargo.toml # core/src/replay_stage.rs # core/src/tvu.rs # geyser-plugin-interface/Cargo.toml # geyser-plugin-manager/Cargo.toml # geyser-plugin-manager/src/geyser_plugin_service.rs # geyser-plugin-manager/src/slot_status_notifier.rs # validator/src/bin/solana-test-validator.rs # validator/src/main.rs
|
I'm gonna try the auto-backport. We'll see how it goes |
mergify bot
added a commit
that referenced
this pull request
Mar 15, 2022
* Rename AccountsDb plugins to Geyser plugins (#23604) (cherry picked from commit 102dd68) # Conflicts: # Cargo.lock # Cargo.toml # core/Cargo.toml # core/src/replay_stage.rs # core/src/tvu.rs # geyser-plugin-interface/Cargo.toml # geyser-plugin-manager/Cargo.toml # geyser-plugin-manager/src/geyser_plugin_service.rs # geyser-plugin-manager/src/slot_status_notifier.rs # validator/src/bin/solana-test-validator.rs # validator/src/main.rs * Fix conflicts Co-authored-by: Tyera Eulberg <tyera@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The name "AccountsDb Plugin" isn't accurate for the implementation, since plugins can now stream blocks and transactions in addition to accounts.
Summary of Changes
Rename to the generic term
geyserCurrently doc references to the
solana-accountsdb-plugin-postgresrepository have been left unchanged, to be updated when that repo is renamed