-
Notifications
You must be signed in to change notification settings - Fork 4.6k
(LedgerStore) Use rocksdb_fifo
as the blockstore directory when FIFO is used
#23236
Conversation
The effect is also verified by running the ledger_cleanup benchmark with FIFO enabled:
Will follow up with more tests on GC. |
Manually test with #23272 by specifying the same ledger path but with different
|
Codecov Report
@@ Coverage Diff @@
## master #23236 +/- ##
========================================
Coverage 81.3% 81.3%
========================================
Files 571 572 +1
Lines 155738 155826 +88
========================================
+ Hits 126682 126810 +128
+ Misses 29056 29016 -40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once steve's comment is addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull request has been modified.
…e. (solana-labs#23236) #### Summary of Changes To avoid mixing the use of different shred storage types, each shred storage type will have its blockstore in a different directory. This PR still keeps the RocksFifo setting hidden. The default ShredStorageType and blockstore directory are still RocksLevel and `rocksdb`. Will follow-up with PRs on making FIFO option public in ledger-tool and validator. #### Test Plan * Added a new test to verify the existence of `rocksdb-fifo` directory when FIFO compaction is used. * Updated existing test to verify the current setting still store ledger under `rocksdb` directory. * Manually ran ledger_cleanup_test with both level and fifo compaction and verified the resulting ledger. * Ran a validator with this PR.
Summary of Changes
To avoid mixing the use of different shred storage types, each shred storage type
will have its blockstore in a different directory.
This PR still keeps the RocksFifo setting hidden. The default ShredStorageType and
blockstore directory are still RocksLevel and
rocksdb
.Will follow-up with PRs on making FIFO option public in ledger-tool and validator.
Test Plan
rocksdb-fifo
directory when FIFO compaction is used.rocksdb
directory.