This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Exit get_signatures_for_address on first BigTable error #22200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omarkilani , what do you think of this? |
omarkilani
reviewed
Dec 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #22200 +/- ##
=======================================
Coverage 81.0% 81.0%
=======================================
Files 523 523
Lines 146470 146480 +10
=======================================
+ Hits 118728 118761 +33
+ Misses 27742 27719 -23 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2021
(cherry picked from commit 0b1b36f)
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2021
(cherry picked from commit 0b1b36f)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#22115 adds a 2nd query to long-term storage. However, if there is an issue with the connection, this could lead the process to wait for two timeouts.
Summary of Changes
Parse BigTable error and queue up 2nd query only on Ok or SignatureNotFound, otherwise return results already found in Blockstore