Disk Buckets: unlock verifies expected

[jeffwashington]

Problem

Summary of Changes

Fixes #

[brooksprumo]

Will unlock() be called in more places? I'm not sure I see a benefit to moving the assert around because it changes the normal/common API for "unlock" functions.

[jeffwashington]

Will unlock() be called in more places? I'm not sure I see a benefit to moving the assert around because it changes the normal/common API for "unlock" functions.

It will likely become a member of a trait. And the concept of Uid will be abstracted to be stored in the data structure of varying # of bits perhaps.

[jeffwashington]

Will unlock() be called in more places? I'm not sure I see a benefit to moving the assert around because it changes the normal/common API for "unlock" functions.

It will likely become a member of a trait. And the concept of Uid will be abstracted to be stored in the data structure of varying # of bits perhaps.

So I want a caller to say, "Here's the full id I expect to be there. Please unlock and verify that this id was there." If the full id is only stored as 1 bit or it is stored as 64 bits, the unlock function knows enough to convert the full u64 uid to 1 bit and compare it.

Pull request has been modified.