This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
AcctIdx: respect disk idx mem size param #22050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22050 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 517 517
Lines 145586 145624 +38
=======================================
+ Hits 118445 118529 +84
+ Misses 27141 27095 -46 |
jeffwashington
force-pushed
the
metrics58
branch
from
944d331 to
d68aa5e
Compare
jeffwashington
force-pushed
the
metrics58
branch
from
d68aa5e to
bbbe52d
Compare
jeffwashington
force-pushed
the
metrics58
branch
from
bbbe52d to
a370c17
Compare
brooksprumo
reviewed
Dec 22, 2021
brooksprumo
approved these changes
Dec 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If clean or cache flushing gets behind, then the in-mem accounts index can grow very large since it is holding items in the cache or items with > 1 account info in memory. When the in-mem accounts index grows large, it can take ever longer to flush, resulting in poor system performance.
Summary of Changes
Respect the max size the cache is allowed to grow to.
Fixes #