Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

AcctIdx: hold ranges in memory uses multiple threads #22031

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Dec 20, 2021

Problem

see comment in code

Summary of Changes

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review December 21, 2021 00:48
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #22031 (008b55d) into master (d896ff7) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 008b55d differs from pull request most recent head 463efc5. Consider uploading reports for the commit 463efc5 to get more accurate results

@@           Coverage Diff           @@
##           master   #22031   +/-   ##
=======================================
  Coverage    81.3%    81.3%           
=======================================
  Files         517      517           
  Lines      145586   145540   -46     
=======================================
+ Hits       118445   118469   +24     
+ Misses      27141    27071   -70     

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea makes sense. I know there's the AccountsDb thread_pool field; would that be applicable to use here, instead of specifying max_threads? (I forget, is this called from a background thread too?)

@jeffwashington
Copy link
Contributor Author

I think the idea makes sense. I know there's the AccountsDb thread_pool field; would that be applicable to use here, instead of specifying max_threads? (I forget, is this called from a background thread too?)

I was thinking I'd avoid that plumbing, but it didn't turn out to be that bad. So, done.

brooksprumo
brooksprumo previously approved these changes Dec 21, 2021
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot dismissed brooksprumo’s stale review December 21, 2021 21:55

Pull request has been modified.

@jeffwashington jeffwashington merged commit bdae299 into solana-labs:master Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants