AcctIdx: StoredSize is u32 #21894
Merged
AcctIdx: StoredSize is u32 #21894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21894 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 516 516
Lines 144033 144220 +187
=========================================
+ Hits 117139 117263 +124
- Misses 26894 26957 +63 |
jeffwashington
force-pushed
the
metrics19
branch
from
3a3ffdc to
1f31e99
Compare
mergify
bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
max acct data len is 10M. So, max acct size in append vec is not much bigger than that. We don't need a usize to store 0-~10M. u32 works great.
Summary of Changes
Reduce in-mem AccountInfo.stored_size to u32 to reduce memory use (and disk-bucket disk use) of AcctIdx.
Fixes #