Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo in the SQL statement #21872

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Fixed a typo in the SQL statement #21872

merged 2 commits into from
Dec 14, 2021

Conversation

lijunwangs
Copy link
Contributor

@lijunwangs lijunwangs commented Dec 14, 2021 •
edited
Loading

Problem

Fixed a couple of errors in the SQL statements

Summary of Changes

  1. Missing enum entry in TransactionErrorCode
  2. Wrong type for account key under TransactionMessageAddressTableLookup
    Fixes #

@lijunwangs lijunwangs force-pushed the fix_transaction_plugin_error branch from 2e90876 to 119de70 Compare December 14, 2021 16:18
jstarry
jstarry previously approved these changes Dec 14, 2021
View reviewed changes
@mergify mergify bot dismissed jstarry’s stale review December 14, 2021 16:23

Pull request has been modified.

@lijunwangs lijunwangs merged commit b610e55 into solana-labs:master Dec 14, 2021
mergify bot pushed a commit that referenced this pull request Dec 22, 2021
@lijunwangs
Fixed a typo in the SQL statement (#21872)
e1eb3ac 
* Fixed a typo in the SQL statement

* Fixed additional two errors in the postgres database objects

(cherry picked from commit b610e55)
@mergify mergify bot mentioned this pull request Dec 22, 2021
Merged
mergify bot added a commit that referenced this pull request Dec 22, 2021
@mergify @lijunwangs
Fixed a typo in the SQL statement (#21872) (#22075)
8f26c71 
* Fixed a typo in the SQL statement

* Fixed additional two errors in the postgres database objects

(cherry picked from commit b610e55)

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarry jstarry jstarry left review comments

@carllin carllin Awaiting requested review from carllin

@sakridge sakridge Awaiting requested review from sakridge

@jeffwashington jeffwashington Awaiting requested review from jeffwashington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lijunwangs @jstarry