Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AcctIdx: use StorageLocation #21853

Merged
merged 1 commit into from
Dec 14, 2021
Merged

AcctIdx: use StorageLocation #21853

merged 1 commit into from
Dec 14, 2021

Conversation

jeffwashington
Copy link
Contributor

@jeffwashington jeffwashington commented Dec 13, 2021 •
edited
Loading

Problem

Provide abstraction for the cached store_id being a special, high value regular store_id. Move towards reducing the data type of store_id.

Summary of Changes

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review December 13, 2021 23:38
@jeffwashington jeffwashington changed the title AcctIdex: use StorageLocation AcctIdx: use StorageLocation Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #21853 (254d372) into master (a400b5e) will decrease coverage by 0.0%.
The diff coverage is 77.5%.

❗ Current head 254d372 differs from pull request most recent head 8b28e81. Consider uploading reports for the commit 8b28e81 to get more accurate results

@@            Coverage Diff            @@
##           master   #21853     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         516      516             
  Lines      144033   144231    +198     
=========================================
+ Hits       117139   117261    +122     
- Misses      26894    26970     +76

brooksprumo
brooksprumo reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Just some nitpicking about names.

runtime/src/account_info.rs Outdated Show resolved Hide resolved
runtime/src/account_info.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
runtime/src/accounts_db.rs Outdated Show resolved Hide resolved
brooksprumo
brooksprumo previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Lgtm

@mergify mergify bot dismissed brooksprumo’s stale review December 14, 2021 15:49

Pull request has been modified.

@jeffwashington jeffwashington merged commit ec583bd into solana-labs:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo left review comments

@carllin carllin Awaiting requested review from carllin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffwashington @brooksprumo