Add code comment for check_insert_data_shred in blockstore.rs #21845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
previously approved these changes
Dec 13, 2021
steviez
previously approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Content looks good to me, please just update the formatting to match Rust conventions, similar to #21837 (comment).
steviez
reviewed
Dec 14, 2021
ledger/src/blockstore.rs
Outdated
| * the insert_shreds_lock as it performs read-modify-write operations | ||
| * on multiple column families. | ||
| * | ||
| * The column families which it may directly update are cf::DeadSlots |
There was a problem hiding this comment.
Similar comment as other PR - maybe mention that changes to these CF's would be added to write_batch
mergify
bot
dismissed stale reviews from carllin and steviez
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #21845 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 516 516
Lines 144217 144217
=======================================
+ Hits 117268 117273 +5
+ Misses 26949 26944 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add code comment for check_insert_data_shred in blockstore.rs