Eagerly receive records in sleepy tick producer #21832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This knocked 5s off the |
jstarry
force-pushed
the
fix-sleepy-producer
branch
from
13ae0c2 to
1003a70
Compare
Codecov Report
@@ Coverage Diff @@
## master #21832 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 516 516
Lines 144033 144177 +144
=========================================
+ Hits 117139 117223 +84
- Misses 26894 26954 +60 |
|
@CriesofCarrots do you mind giving this a quick look? |
Will do today, sorry for the delay! |
CriesofCarrots
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the sleepy poh tick producer runs for tests, it doesn't process new Poh records while it sleeps. This causes some tests to get artificially delayed because they need to wait for the Poh recorder to confirm that each tx was recorded.
Summary of Changes
Move sleep duration to the record receiver timeout so that sleeps don't slow down new tx records
Fixes #