Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds ShredId uniquely identifying each shred #21820

Merged
merged 1 commit into from
Dec 14, 2021
Merged

adds ShredId uniquely identifying each shred #21820

merged 1 commit into from
Dec 14, 2021

Conversation

behzadnouri
Copy link
Contributor

Problem

(slot, shred_index, shred_type) scattered through out the code for identifying shreds.

Summary of Changes

added ShredId type for uniquely identifying shreds.

@codecov
Copy link

codecov bot commented Dec 12, 2021 •
edited
Loading

Codecov Report

Merging #21820 (4b237bb) into master (033106e) will decrease coverage by 0.0%.
The diff coverage is 95.3%.

@@            Coverage Diff            @@
##           master   #21820     +/-   ##
=========================================
- Coverage    81.3%    81.2%   -0.1%     
=========================================
  Files         516      516             
  Lines      144217   144226      +9     
=========================================
- Hits       117268   117249     -19     
- Misses      26949    26977     +28

carllin
carllin previously approved these changes Dec 13, 2021
View reviewed changes
@mergify mergify bot dismissed carllin’s stale review December 14, 2021 14:12

Pull request has been modified.

@behzadnouri behzadnouri merged commit 4ceb268 into solana-labs:master Dec 14, 2021
@behzadnouri behzadnouri deleted the shred-id branch December 14, 2021 17:34
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
@behzadnouri
adds ShredId uniquely identifying each shred (#21820)
c5c0dfd 
(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs
@mergify mergify bot mentioned this pull request Dec 14, 2021
Merged
mergify bot added a commit that referenced this pull request Dec 14, 2021
@mergify @behzadnouri
adds ShredId uniquely identifying each shred (backport #21820) (#21897)
2f1816d 
* adds ShredId uniquely identifying each shred (#21820)

(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs

* removes backport merge conflicts

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Closed
mergify bot pushed a commit that referenced this pull request Feb 4, 2022
@behzadnouri
adds ShredId uniquely identifying each shred (#21820)
bd13dc0 
(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs
@mergify mergify bot mentioned this pull request Feb 4, 2022
Merged
mergify bot added a commit that referenced this pull request Feb 4, 2022
@mergify @behzadnouri
adds ShredId uniquely identifying each shred (backport #21820) (#22940)
9361a50 
* adds ShredId uniquely identifying each shred (#21820)

(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs

* removes mergify merge conflicts

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllin carllin carllin left review comments

@jbiseda jbiseda Awaiting requested review from jbiseda

@sakridge sakridge Awaiting requested review from sakridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behzadnouri @carllin