Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove activated feature that checks tx signature len #21747

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Dec 9, 2021

Problem

Now that the feature to check transaction signatures length is activated on all clusters, it can be removed and the length check can be moved into transaction sanitization checking.

Summary of Changes

Fixes #

@jstarry jstarry force-pushed the remove-extra-sig-feature branch from 2269edd to b0f22e8 Compare December 10, 2021 16:31
@jstarry jstarry force-pushed the remove-extra-sig-feature branch from b0f22e8 to 9a2f7e5 Compare December 10, 2021 19:03
@jstarry jstarry requested a review from t-nelson December 10, 2021 21:21
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #21747 (9a2f7e5) into master (6fc3291) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #21747   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         511      511           
  Lines      143469   143459   -10     
=======================================
- Hits       116840   116832    -8     
+ Misses      26629    26627    -2     

@jstarry jstarry requested review from joncinque and removed request for t-nelson December 13, 2021 15:13
@jstarry
Copy link
Member Author

jstarry commented Dec 13, 2021

@joncinque could you sanity check this, please?

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was surprisingly tricky, but looks good!

@jstarry jstarry added the v1.9 label Dec 14, 2021
@jstarry jstarry merged commit e547691 into solana-labs:master Dec 14, 2021
@jstarry jstarry deleted the remove-extra-sig-feature branch December 14, 2021 14:23
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants