AcctIdx: move zero lamport out of accounts index #21526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
metrics17
branch
from
5bb6744 to
37747ed
Compare
carllin
reviewed
Dec 9, 2021
carllin
reviewed
Dec 9, 2021
carllin
reviewed
Dec 9, 2021
carllin
reviewed
Dec 9, 2021
jeffwashington
force-pushed
the
metrics17
branch
5 times, most recently
from
599ac3e to
4e2fc3f
Compare
brooksprumo
reviewed
Dec 13, 2021
brooksprumo
reviewed
Dec 13, 2021
jeffwashington
force-pushed
the
metrics17
branch
from
4e2fc3f to
3b4cf33
Compare
brooksprumo
previously approved these changes
Dec 13, 2021
Comment on lines
+1
to
+4
| //! AccountInfo represents a reference to AccountSharedData in either an AppendVec or the write cache. | ||
| //! AccountInfo is not persisted anywhere between program runs. | ||
| //! AccountInfo is purely runtime state. | ||
| //! Note that AccountInfo is saved to disk buckets during runtime, but disk buckets are recreated at startup. |
There was a problem hiding this comment.
Thanks for the doc comments!
Codecov Report
@@ Coverage Diff @@
## master #21526 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 516 516
Lines 144033 144192 +159
=========================================
+ Hits 117139 117230 +91
- Misses 26894 26962 +68 |
jeffwashington
force-pushed
the
metrics17
branch
from
3b4cf33 to
1477b5f
Compare
mergify
bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lamport balance in account index is an optimization for shrinking (maybe also cleaning). But, this information already exists in the code path that produces lists of pubkeys.
Thus, lamports in the accounts index require the accounts index entries to be larger. Larger means more space in memory, less cache hits, more size on disk, more pages needing to map in, etc. These issues become worse with disk buckets and 10B accounts.
Summary of Changes
Remove lamports from an AccountsIndex entry for perf.
Note that the first attempt was trying to calculate the zero lamport information in clean and shrink. This proved to be difficult with deferred dirty keys.
Fixes #