This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Bank drop service #21322
Merged
Bank drop service #21322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
bank-drop-service
branch
from
8242a02 to
558a4e5
Compare
sakridge
force-pushed
the
bank-drop-service
branch
from
558a4e5 to
353ab28
Compare
sakridge
force-pushed
the
bank-drop-service
branch
from
353ab28 to
9265214
Compare
Codecov Report
@@ Coverage Diff @@
## master #21322 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 500 501 +1
Lines 140511 140590 +79
=========================================
+ Hits 114655 114664 +9
- Misses 25856 25926 +70 |
|
1.8.5 node: Node with this fix: |
carllin
reviewed
Nov 18, 2021
| let mut dropped_banks_time = Measure::start("drop_banks"); | ||
| drop(banks); | ||
| dropped_banks_time.stop(); | ||
| if dropped_banks_time.as_ms() > 10 { |
There was a problem hiding this comment.
Maybe worth logging a datapoint for each individual bank for each slot in case it's something bank specific?
Also not a big deal, but I think it's possible some other thread has an outstanding reference to some Arc root bank even after it was removed in the replay path (something like, RPC or the vote listener) but this at least unblocks replay.
CriesofCarrots
approved these changes
Nov 18, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2021
(cherry picked from commit 0bda0c3) # Conflicts: # core/src/lib.rs # core/src/replay_stage.rs # core/src/tvu.rs # core/src/vote_simulator.rs
sakridge
added a commit
that referenced
this pull request
Nov 19, 2021
(cherry picked from commit 0bda0c3)
sakridge
added a commit
that referenced
this pull request
Nov 19, 2021
(cherry picked from commit 0bda0c3)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Nov 19, 2021
sakridge
added a commit
that referenced
this pull request
Nov 19, 2021
(cherry picked from commit 0bda0c3)
sakridge
added a commit
that referenced
this pull request
Nov 19, 2021
(cherry picked from commit 0bda0c3)
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit d379f09.
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
This reverts commit b030d4b.
tao-stones
pushed a commit
that referenced
this pull request
Dec 13, 2021
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
CriesofCarrots
pushed a commit
that referenced
this pull request
Dec 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dropping banks can be expensive and it's bad to stall the replay stage loop.
Summary of Changes
Drop banks in another thread.
Fixes #