This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor slot status notification to decouple from accounts notifications #21308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21308 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 500 501 +1
Lines 140526 140555 +29
=========================================
+ Hits 114582 114604 +22
- Misses 25944 25951 +7 |
lijunwangs
changed the title
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…ions (solana-labs#21308) Problem Slot status can be used of in other scenarios in addition to account information such as transactions, blocks. The current implementation is too tightly coupled. Summary of Changes Decouple the slot status notification from accounts notification. Created a new slot status notification module.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…otifications (solana-labs#21308)" This reverts commit 7b3ff7c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Slot status can be used of in other scenarios in addition to account information such as transactions, blocks. The current implementation is too tightly coupled.
Summary of Changes
Decouple the slot status notification from accounts notification. Created a new slot status notification module.
Note: This is the first batch by breaking down #21247.
Fixes #