This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
check OS network limits when starting validator #20874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Oct 22, 2021
validator/src/main.rs
Outdated
| let err_msg = "OS network limit test failed. If you wish to continue, try --no-os-network-limits-test"; | ||
| error!("{}", err_msg); | ||
| eprintln!("{}", err_msg); | ||
| exit(1); |
There was a problem hiding this comment.
I'm a little worried this is too aggressive. How about emitting a datapoint instead of failing here, so we can see how many validators get snagged here first
There was a problem hiding this comment.
Same. If the metric is out of control we can remediate it down to a more comfortable level before adding the boot
There was a problem hiding this comment.
Wanted to get an opinion on this. Changed to log a datapoint.
t-nelson
reviewed
Oct 22, 2021
validator/src/main.rs
Outdated
| let err_msg = "OS network limit test failed. If you wish to continue, try --no-os-network-limits-test"; | ||
| error!("{}", err_msg); | ||
| eprintln!("{}", err_msg); | ||
| exit(1); |
There was a problem hiding this comment.
Same. If the metric is out of control we can remediate it down to a more comfortable level before adding the boot
mvines
previously approved these changes
Oct 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #20874 +/- ##
=========================================
+ Coverage 81.4% 81.5% +0.1%
=========================================
Files 531 496 -35
Lines 141636 139627 -2009
Branches 295 0 -295
=========================================
- Hits 115312 113928 -1384
+ Misses 26224 25699 -525
+ Partials 100 0 -100 |
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-sys-tunercan be used to increase linux network buffer sizes, but we do not check that these values have been applied.Summary of Changes
Check that linux network buffer sizes have been increased in validator start. Checks can be bypassed with
--no-os-network-limits-test.Fixes #