Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): missing import #20788

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix(docs): missing import #20788

merged 1 commit into from
Oct 26, 2021

Conversation

cogoo
Copy link
Contributor

@cogoo cogoo commented Oct 19, 2021

add missing import of Connection

Problem

Connection import missing

Summary of Changes

Documentation only changes

@mergify mergify bot added the community Community contribution label Oct 19, 2021
@mergify mergify bot requested a review from a team October 19, 2021 16:29
@t-nelson
Copy link
Contributor

@jstarry can you advise on the CI failure? 🙏

@cogoo
Copy link
Contributor Author

cogoo commented Oct 20, 2021

@jstarry can you advise on the CI failure? 🙏

My initial thought was that a flakey test failed? Or something completely unrelated

@t-nelson
Copy link
Contributor

probably. it failed again on retry though. called in the experts

@cogoo
Copy link
Contributor Author

cogoo commented Oct 26, 2021

Is there a way to trigger a re-run of this?

@CriesofCarrots
Copy link
Contributor

@cogoo , I think you're running into this issue: #20803
Can you please rebase your branch to pick up that fix?

@cogoo
Copy link
Contributor Author

cogoo commented Oct 26, 2021

@cogoo , I think you're running into this issue: #20803 Can you please rebase your branch to pick up that fix?

awesome, will do 👍🏾

@cogoo
fix(docs): missing import
20bfc6b 
add missing import of `Connection`
@CriesofCarrots
Copy link
Contributor

All good now :) Thank you!

@CriesofCarrots CriesofCarrots merged commit 521b7b7 into solana-labs:master Oct 26, 2021
@cogoo
Copy link
Contributor Author

cogoo commented Oct 26, 2021

All good now :) Thank you!

Thanks for your time!

mergify bot pushed a commit that referenced this pull request Oct 26, 2021
@cogoo
fix(docs): missing import (#20788)
3184dac 
add missing import of `Connection`

(cherry picked from commit 521b7b7)
@mergify mergify bot mentioned this pull request Oct 26, 2021
Merged
mergify bot added a commit that referenced this pull request Oct 26, 2021
@mergify @cogoo
fix(docs): missing import (#20788) (#20996)
9e81798 
add missing import of `Connection`

(cherry picked from commit 521b7b7)

Co-authored-by: Colin Ogoo <ogoo.colin@gmail.com>
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
@cogoo @dankelleher
fix(docs): missing import (solana-labs#20788)
65d86b0 
add missing import of `Connection`
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
@frits-metalogix
Revert "fix(docs): missing import (solana-labs#20788)"
3ffa420 
This reverts commit 65d86b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cogoo @t-nelson @CriesofCarrots