charge for ed25519 sig verifies #20639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20639 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 495 495
Lines 137701 137770 +69
=======================================
+ Hits 112832 112930 +98
+ Misses 24869 24840 -29 |
seanyoung
previously approved these changes
Oct 13, 2021
jackcmay
force-pushed
the
charge-sig-fee-for-ed25519-precompiles
branch
from
10a7958 to
8861d09
Compare
mergify
bot
dismissed
seanyoung’s stale review
Pull request has been modified.
jackcmay
force-pushed
the
charge-sig-fee-for-ed25519-precompiles
branch
from
8861d09 to
21a6e0a
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
(cherry picked from commit 4beabb3) # Conflicts: # sdk/program/src/message/sanitized.rs
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 6fe7c6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missed charging for ed25519 signatures.
Summary of Changes
Charge for them, no feature gated needed because ed25519 program ids are rejected until that feature is enabled.
Fixes #