Fix dos data-type for non-gossip mode #20465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
dos-data-type
branch
from
cafd685 to
757bf45
Compare
Codecov Report
@@ Coverage Diff @@
## master #20465 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 495 495
Lines 136481 136481
=======================================
+ Hits 112734 112735 +1
+ Misses 23747 23746 -1 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
(cherry picked from commit b178f3f)
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 55d2a25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
data-type setting checks for nodes.empty but doesn't need to. Only for the repair cases where it actually picks a random target.
Summary of Changes
Make a helper for repair data cases and generate data according to the parameter in other cases.
Fixes #