This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add bank to banking stage regardless of if there is a working bank #19855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19855 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 478 478
Lines 133420 133450 +30
=======================================
+ Hits 110256 110335 +79
+ Misses 23164 23115 -49 |
jstarry
approved these changes
Sep 17, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
… bank (solana-labs#19855)" This reverts commit 8267e8e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BankingStage needs a bank to access stakes, but currently
PohRecorderonly supports the working bank when the validator is the leaderSummary of Changes
Add
get_poh_recorder_bank()API to get a bank fromPohRecorderregardless if we are the leaderFixes #