This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor genesis download/load/check functions #17276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
genesis-utils-refactor
branch
2 times, most recently
from
e0f1634 to
951f734
Compare
sakridge
force-pushed
the
genesis-utils-refactor
branch
from
951f734 to
039bbb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #17276 +/- ##
=========================================
- Coverage 82.7% 82.6% -0.1%
=========================================
Files 421 422 +1
Lines 117913 117950 +37
=========================================
- Hits 97557 97529 -28
- Misses 20356 20421 +65 |
ryoqun
approved these changes
May 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Genesis download code could be useful for another client that wants to download genesis, load it and check the hash.
Summary of Changes
Refactor into genesis-utils crate from validator/src/main.rs
Fixes #