This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add allowed-IP list to faucet #16891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16891 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 414 414
Lines 115659 115709 +50
=======================================
+ Hits 95715 95771 +56
+ Misses 19944 19938 -6 |
mvines
reviewed
Apr 27, 2021
CriesofCarrots
force-pushed
the
faucet-whitelist
branch
from
ae3cc0c to
6779c9b
Compare
CriesofCarrots
changed the title
|
@mvines I went with just |
mvines
approved these changes
Apr 28, 2021
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
(cherry picked from commit 36574c3)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #16487
Airdrop requests sent to the same rpc node appear to the faucet with the same source IP address, regardless of the IP that sent the rpc request. If this IP is not the loopback address (as in the case of load-balanced api nodes remote from the faucet), airdrop requests will be overly limited by a faucet running with a per-time-cap, limiting all users together instead of per IP as intended.
Summary of Changes
Add allowed-IP list to faucet; IPs listed are excluded from ip limiting (address limits still checked/applied)
cc @joeaba