This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Bump tokio to 1.1 in ledger crate #15926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed locally that this prevents the panic |
mvines
approved these changes
Mar 16, 2021
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #15926 +/- ##
=========================================
- Coverage 80.0% 80.0% -0.1%
=========================================
Files 409 409
Lines 106542 106542
=========================================
- Hits 85247 85245 -2
- Misses 21295 21297 +2 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2021
(cherry picked from commit 654449c)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Old tokio version in ledger crate causes a node panic if
bigtable.get_confirmed_blocks()ever fails (eg dropped connection, etc), since it is called in newer tokio via core/src/bigtable_upload_serviceSummary of Changes
Bump ledger tokio version to match the rest of the project
Fixes #15924