Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Cap number of program address seeds #13925

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Dec 2, 2020

Problem

create_program_address has no cap on the number of seeds that can be passed which can lead to a large hash compute load

Summary of Changes

Cap the maximum number of seeds to a reasonable amount

Fixes #

@jackcmay jackcmay added the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2020

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2020

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2020

automerge label removed due to a CI failure

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@mergify mergify bot merged commit e6f54ff into solana-labs:v1.4 Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #13925 (9b8a38d) into v1.4 (501fea7) will decrease coverage by 0.0%.
The diff coverage is 33.3%.

@@           Coverage Diff            @@
##            v1.4   #13925     +/-   ##
========================================
- Coverage   82.2%    82.2%   -0.1%     
========================================
  Files        382      382             
  Lines      92982    92990      +8     
========================================
+ Hits       76452    76456      +4     
- Misses     16530    16534      +4     

@jackcmay jackcmay deleted the cap-seeds-v1.4 branch December 2, 2020 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants