Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Cli: output stake account credits-observed for verbose/json #13923

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

CriesofCarrots
Copy link
Contributor

Problem

We removed credits-observed data from the cli display because it is not super accessible to users. It is still available via JSON-RPC, however it would be useful for inflation analysis to be able to get this information quickly via cli.

Summary of Changes

  • Add credits_observed to verbose and json CliStakeStake prints

cc @ryoqun

t-nelson
t-nelson previously approved these changes Dec 2, 2020
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple nits, should you choose

cli-output/src/cli_output.rs Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed t-nelson’s stale review December 2, 2020 20:48

Pull request has been modified.

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #13923 (e0b37be) into master (85bec37) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           master   #13923     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         382      382             
  Lines       93635    93654     +19     
=========================================
+ Hits        76900    76906      +6     
- Misses      16735    16748     +13     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants