This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add counter metrics to rpc-subscriptions #13596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13596 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 378 378
Lines 90891 90895 +4
=======================================
+ Hits 74624 74628 +4
Misses 16267 16267 |
mvines
approved these changes
Nov 14, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2020
(cherry picked from commit 88ae321)
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2020
(cherry picked from commit 88ae321)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rpc-subscription metrics only include bank/gossip notifications, those that we expected to be the longest-running, but not necessarily the most frequent.
Summary of Changes