This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Decouple transaction modules #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aeyakovenko, not included here, but badly needed is to create a ValidateTransaction where the userdata is simply Vote. Without that cleanup, BudgetTransaction is used all over the codebase even though the only true dependencies are way up in the client. |
These functions pull in budget-specific and system-specific dependencies that aren't needed by the runtime.
garious
force-pushed
the
decouple-tx-modules
branch
from
f609a30 to
ed1877f
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…js (solana-labs#1351) Bumps [eslint](https://github.com/eslint/eslint) from 7.20.0 to 7.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.20.0...v7.21.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TESLA-SATI
pushed a commit
to TESLA-SATI/solana
that referenced
this pull request
May 15, 2024
* exit early if cache is empty * remove unnecessary warn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module transaction.rs contained dependencies on the Budget and System program data structures. The upcoming solana linker depends on the raw Transaction data structure, which we'll use to load the Budget and System programs. Those dependencies needed to be boot from transaction.rs so that we can use the linker to load the Budget and System programs. This PR does only that.