Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

builds crds filters in parallel (bp #12360) #12571

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 29, 2020

This is an automated backport of pull request #12360 done by Mergify

Cherry-pick of 537bbde has failed:

On branch mergify/bp/v1.3/pr-12360
Your branch is up to date with 'origin/v1.3'.

You are currently cherry-picking commit 537bbde22.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   Cargo.lock
	modified:   core/benches/crds_gossip_pull.rs
	modified:   core/src/cluster_info.rs
	modified:   core/src/crds_gossip.rs
	modified:   core/src/crds_gossip_pull.rs
	modified:   core/tests/crds_gossip.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   core/Cargo.toml

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

Based on run-time profiles, the majority time of new_pull_requests is
spent building bloom filters, in hashing and bit-vec ops.

This commit builds crds filters in parallel using rayon constructs. The
added benchmark shows ~5x speedup (4-core machine, 8 threads).

(cherry picked from commit 537bbde)

# Conflicts:
#	core/Cargo.toml
@mergify mergify bot added conflicts automerge Merge this Pull Request automatically once CI passes labels Sep 29, 2020
@mergify
Copy link
Contributor Author

mergify bot commented Sep 29, 2020

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Sep 29, 2020
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Sep 29, 2020
@mergify mergify bot merged commit 55b0e9e into v1.3 Sep 30, 2020
@mergify mergify bot deleted the mergify/bp/v1.3/pr-12360 branch September 30, 2020 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant