This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix banks RPC port #12570
Merged
Fix banks RPC port #12570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
added
v1.3
automerge
Codecov Report
@@ Coverage Diff @@
## master #12570 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 356 356
Lines 83121 83125 +4
=========================================
- Hits 68186 68167 -19
- Misses 14935 14958 +23 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2020
* Fix Banks RPC ports * Add get_account_with_commitment (cherry picked from commit d158d45)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The BanksServer port is calculated as 3 above the RPC port. If no RPC port is provided, it uses 80 (or 443) instead of 8899.
Summary of Changes
BanksClientExt::get_account_with_commitmentwhile in the neighborhoodcc: @CriesofCarrots @mvines