This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove transaction encoding from storage layer #12404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
bigtable-confirmed-block
branch
from
d90fd1b to
62bcdaa
Compare
jstarry
force-pushed
the
bigtable-confirmed-block
branch
from
62bcdaa to
7d6710e
Compare
Codecov Report
@@ Coverage Diff @@
## master #12404 +/- ##
=========================================
- Coverage 82.2% 82.2% -0.1%
=========================================
Files 346 346
Lines 81481 81463 -18
=========================================
- Hits 67016 66991 -25
- Misses 14465 14472 +7 |
|
Adding backports since this is a prereq for surfacing CPI's |
mvines
approved these changes
Sep 24, 2020
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
(cherry picked from commit 731a943) # Conflicts: # ledger-tool/src/bigtable.rs # ledger/src/blockstore.rs
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
(cherry picked from commit 731a943) # Conflicts: # ledger-tool/src/bigtable.rs
jstarry
added a commit
that referenced
this pull request
Sep 24, 2020
(cherry picked from commit 731a943)
jstarry
added a commit
that referenced
this pull request
Sep 24, 2020
(cherry picked from commit 731a943)
|
skipped the v1.2 backport |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transaction encoding is done in the storage layer (bigtable / blockstore) when it really only needs to be done at the api layer (RPC). The current implementation couples the storage types with "UI"/"Encoded" types which adds extra data conversion overhead that isn't necessary. It also does unnecessary transaction serialization
Context: This makes it easier to separate API invoked instruction types from storage invoked instruction types here: #12311
Summary of Changes
Encoded..flavors ofConfirmedBlock,ConfirmedTransaction, etc.Fixes #