This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: Add until parameter for getConfirmedSignaturesForAddress2 #11644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 14, 2020 14:43
Codecov Report
@@ Coverage Diff @@
## master #11644 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 330 330
Lines 76106 76198 +92
=========================================
+ Hits 62506 62561 +55
- Misses 13600 13637 +37 |
mvines
previously approved these changes
Aug 15, 2020
CriesofCarrots
force-pushed
the
bigtable-sigs-until
branch
from
40dd761 to
5fba5f1
Compare
Indeed! It's a joy |
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2020
* Refactor bigtable apis to accept start and end keys * Make helper fn to deserialize cell data * Refactor get_confirmed_signatures_for_address to use get_row_data range * Add until param to get_confirmed_signatures_for_address * Add until param to blockstore api * Plumb until through client/cli * Simplify client params (cherry picked from commit 6c5b8f3)
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2020
* Refactor bigtable apis to accept start and end keys * Make helper fn to deserialize cell data * Refactor get_confirmed_signatures_for_address to use get_row_data range * Add until param to get_confirmed_signatures_for_address * Add until param to blockstore api * Plumb until through client/cli * Simplify client params (cherry picked from commit 6c5b8f3)
mergify bot
added a commit
that referenced
this pull request
Aug 15, 2020
… (#11648) * Refactor bigtable apis to accept start and end keys * Make helper fn to deserialize cell data * Refactor get_confirmed_signatures_for_address to use get_row_data range * Add until param to get_confirmed_signatures_for_address * Add until param to blockstore api * Plumb until through client/cli * Simplify client params (cherry picked from commit 6c5b8f3) Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Aug 15, 2020
… (#11647) * Refactor bigtable apis to accept start and end keys * Make helper fn to deserialize cell data * Refactor get_confirmed_signatures_for_address to use get_row_data range * Add until param to get_confirmed_signatures_for_address * Add until param to blockstore api * Plumb until through client/cli * Simplify client params (cherry picked from commit 6c5b8f3) Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getConfirmedSignaturesForAccount2allows searching before a certain signature but doesn't support searching recent history up until a signature that you already have. Usinguntilwould be useful when refreshing the explorer UI to check if any new signatures have been confirmed since the last fetch.Summary of Changes
untilrequestsget_row_datarange inget_confirmed_signatures_for_addressuntilparameter togetConfirmedSignaturesForAccount2rpcuntilthrough client/cli apisFixes #11446