This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our services typically communicate with channels. By using channels, we can easily swap out what's on the other end. In the case of something upstream from SendTransactionService, it's sometimes useful to swap out SendTransactionService for something that doesn't require a UDP socket.
Summary of Changes
Refactor SendTransactionService to send transactions after receiving them instead of just before sending. This allows us to remove the
send()
method and expose theReceiver<TransactionInfo>
directly. Upstream users of the service then no longer need to hold the object unless they intend to calljoin()
on it. Instead, pass the upstream aSender<TransactionInfo>
, which may or may not have a SendTransactionService on the other end.