This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix fork detection #10839
Merged
Fix fork detection #10839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10839 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 303 303
Lines 71087 71099 +12
=========================================
- Hits 58227 58220 -7
- Misses 12860 12879 +19 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2020
* Fix fork detection Co-authored-by: Carl <carl@solana.com> (cherry picked from commit 4b93a7c)
carllin
added a commit
that referenced
this pull request
Jun 30, 2020
* Fix fork detection Co-authored-by: Carl <carl@solana.com> (cherry picked from commit 4b93a7c)
carllin
added a commit
that referenced
this pull request
Jun 30, 2020
* Fix fork detection Co-authored-by: Carl <carl@solana.com> (cherry picked from commit 4b93a7c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current fork detection mechanism will report a fork whenever
vote bank.slot() != Some(reset_bank.slot()). However, there are cases when this is true and no fork exists. For instance, if some validators are falling behind and we can't vote due to a threshold failure, then vote bank will beNone.Summary of Changes
Switch to simpler fork detection, if heaviest bank is not a descendant of the last vote, then a fork must exist.
Fixes #