This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Trigger all CI jobs for Dockerfile changes #10651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is working as intended:
|
This reverts commit 801cf2b.
ryoqun
commented
Jun 17, 2020
| @@ -41,7 +42,8 @@ affects() { | |||
| # the worse (affected) | |||
| return 0 | |||
| fi | |||
| for pattern in "$@"; do | |||
| # Assume everyting needs to be tested when any Dockerfile changes | |||
There was a problem hiding this comment.
@mvines FYI, I think this is safe bet. :)
ryoqun
changed the title
ryoqun
changed the title
ryoqun
changed the title
|
@mvines I'm going to merge this because this is minor and I checked this doesn't affect normal CI jobs at all. Feel free to do any post-merge comments! I'll gladly address them! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
I was completely blind of incompatibility of #10585 and the CI
docsjob... Causing some noises: #10633, #10634, #10640.solution
Run the docs job when we're updating nightly docker image!I broadened yet more to re-test all the jobs.