This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Invalid field in notify_block_metadata for geyser #33829
Closed
Description
Here bank.parent_hash()
used as parent_blockhash
for notify_block_metadata()
func and futher send as parent_blockhash
field into GeyserPlugin notify_block_metadata()
:
https://github.com/solana-labs/solana/blob/421b1d4f88148064f5f91eaf24d2481caea1ea3a/core/src/replay_stage.rs#L2844C25-L2844C57
This field in fact incorrect, because parent_blockhash must represent blockhash, but not a hash of parent block
I propose to add here
https://github.com/solana-labs/solana/blob/667bc163426aa075e127d7e58e06ffb11f9e20a2/runtime/src/bank.rs#L1561C15-L1561C15
not only parent_hash, but also parent_blockhash field and build it as parent_blockhash: parent.last_blockhash()
And futher use this field instead of parent_hash for notify_block_metadata
Metadata
Assignees
Labels
No labels
Activity