This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Use the SHA-256 implementation built into JavaScript engines #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
Oct 16, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@solana/spl-type-length-value", | |||
| "description": "SPL Type Length Value Library", | |||
| "version": "0.1.0", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
Breaking change.
steveluscher
commented
Oct 16, 2024
| export async function splDiscriminate(discriminator: string, length = 8): Promise<Uint8Array> { | ||
| assertDigestCapabilityIsAvailable(); | ||
| const bytes = new TextEncoder().encode(discriminator); | ||
| const digest = await crypto.subtle.digest('SHA-256', bytes); |
There was a problem hiding this comment.
Ugh. crypto wasn't added as a global until Node 19. Node 20 is presently LTS.
Our choices are:
- Elevate the requirements to Node 19, or
- Introduce a dual-build Node/Browser system like we have in
@solana/web3.jstosolana-program-library.
There was a problem hiding this comment.
I think we can keep it simple and elevate the requirement for this package to Node 19. Considering it'll become a dev dependency for the two packages that use it, I can't see any drawbacks. Are there any other potential negative consequences that I'm missing?
There was a problem hiding this comment.
As part of that change, can you also update CI to only run the 'libraries' step for node v20?
solana-program-library/.github/workflows/pull-request-js.yml
Lines 43 to 61 in b1e526d
steveluscher
force-pushed
the
for-sha
branch
4 times, most recently
from
d4f790a to
fa04fe7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change which removes the need for browsers to introduce a polyfill for
createHash. Engines now have a built-inSubtleCrypto#digestwhich serves this purpose, polyfill-free, with good support.The reason this is a breaking change is that
createHashis synchronous andSubtleCrypto#digestis async.Related to #7351.