This repository was archived by the owner on Mar 11, 2025. It is now read-only.
[token-2022] Remove unnecessary split proof generation logic #7164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Aug 19, 2024
| .iter() | ||
| .all(|proof_account| proof_account.is_some()) | ||
| { | ||
| // is all proofs come from accounts, then skip proof generation |
There was a problem hiding this comment.
nit:
Suggested change
| // is all proofs come from accounts, then skip proof generation | |
| // if all proofs come from accounts, then skip proof generation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the token-client handles to create confidential transfer instructions that require split zkp's always generate the proof data. However, this is wasteful in that if all of the proofs are pre-verified using a context-state account or already generated and stored in a record account, then there is no need to generate the split proofs.
Summary of Changes
Update the client logic so that for the special case of when the proof accounts are all
Some(...), we skip proof generation.