This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-cli: Add tests for all cases from docs #3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mut bulk_signers: Vec<Box<dyn Signer>>, | ||
| ) -> CommandResult { | ||
| match (sub_command, sub_matches) { | ||
| ("bench", arg_matches) => bench_process_command( |
There was a problem hiding this comment.
I spent too long trying to figure out why this went from Some(arg_matches) to arg_matches... wow, our handling of matches/arg_matches/sub_matches was dumb. Thanks for cleaning it up!
They get run as part of |
|
Aha, yep, did miss it. I think the log didn't expand fully when I was searching for test names. Thanks! |
CriesofCarrots
approved these changes
Apr 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token CLI has no tests, making it hard to see if token-2022 will also be supported from the CLI.
Solution
Refactor the CLI to be testable, and add tests inspired by the docs.
Note: due to the build issue on
solana-test-validatorwith the yanked lru crate, this depends on the upgrade to 1.10.7. Once the upgrade is pushed, this can useTestValidatoreverywhere. Currently, in my own testing environment, I have it run against a test validator.