This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Governance: voter-weight-addin cleanup #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: build addin during test run fix: build voter weight addin for tests using the addin only chore: use mutex to build addin only once chore: move build guard to separate file chore: update governance version for chat
SebastianBor
changed the title
joncinque
reviewed
Oct 18, 2021
joncinque
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR address feedback from #2450
spl_governance_voter_weight_addin.sodoesn't exist it's built before runninggovernancetests.spl_governance_voter_weight_addindoesn't have dependency onspl_governnace_chatany longer.spl_governance_toolscrate was create for shared utilities in the governance programs ecosystem.reservedfields onRealmConfigAccountrenamed to concreteadd-insthey are reserved for