Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move targetDir inside perform_action #147

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Move targetDir inside perform_action #147

merged 4 commits into from
Jul 22, 2020

Conversation

CriesofCarrots
Copy link
Contributor

Fixes #146

@CriesofCarrots CriesofCarrots requested a review from jackcmay July 22, 2020 20:26
@jackcmay
Copy link
Contributor

does targetDir need to reference $3 instead of $2?

@jackcmay
Copy link
Contributor

Also, we probably don't need or want that if statement, should always strip

if [ -f "$so_path/${so_name}.so" ]; then

jackcmay
jackcmay previously approved these changes Jul 22, 2020
View reviewed changes
@mergify mergify bot dismissed jackcmay’s stale review July 22, 2020 23:00

Pull request has been modified.

@CriesofCarrots CriesofCarrots merged commit 2463982 into solana-labs:master Jul 22, 2020
@CriesofCarrots CriesofCarrots deleted the fix-do-all branch September 24, 2020 19:22
ngundotra pushed a commit to ngundotra/solana-program-library that referenced this pull request Aug 16, 2022
@samwise2
Merge pull request solana-labs#147 from jarry-xiao/creator-shares-fix
2f82753 
Fix Creators to Sum to 100 [Bubblegum, Gumball Machine, Sugar Shack]
ngundotra pushed a commit to ngundotra/solana-program-library that referenced this pull request Aug 30, 2022
@samwise2
Merge pull request solana-labs#147 from jarry-xiao/creator-shares-fix
34c9ccd 
Fix Creators to Sum to 100 [Bubblegum, Gumball Machine, Sugar Shack]
codewithgun pushed a commit to MeteoraAg/solana-program-library that referenced this pull request Feb 20, 2024
@0xripleys @nope-finance
V2.0.2 (solana-labs#153)
38ee67e 
* try running CI on big runners (solana-labs#126)

* pack / unpack unit tests (solana-labs#135)

* Isolated Tier Assets (solana-labs#134)

* socialize loss feature (solana-labs#136)

* Liquidation changes (solana-labs#139)

* fully liquidate obligation liquidity if borrow value is < 1 and
correctly handle dust

* cap forgiveness amount wrt ctoken ratio (solana-labs#144)

* On liq, assets must be repaid in order of borrow weight (decending) (solana-labs#141)

* highest borrow weight liquidity must be repaid first

* order borrows by (borrow weight, mint pubkey) and don't convert borrow
weight to decimal

* risk authority (solana-labs#142)

* added risk authority to lending market, setLendingMarketOwnerAndConfig
instruction, and fixed tests

* modified update_reserve_config to use risk authority + tests

* update comment math and handle program upgrade case for risk authority

* add back compute units to tests (solana-labs#150)

* adding compute unit limits

* adding back compute units to test

* Trilinear interest rates (solana-labs#149)

* trilinear interest rates

* edge case handling in Reserve::unpack

* rename unhealthy utilization rate to max utilization rate

* pr comment

* Onchain metadata (solana-labs#151)

* metadata

* metadata

* making LendingMarketMetadata zero copy

* add lookup tables

* review fixes

* verify serialized tx size

---------

Co-authored-by: 0xripleys <0xripleys@solend.fi>

* 0xripleys dynamic liquidation bonus (solana-labs#147)

* dynamic liquidation bonus

* changing the behavior of protocol_liquidation_fee

* comment add

* tests for calculate protocol liquidation fee

* adding more safeguards wrt bonus checking

* add tests that use protocol_liquidation_fee

* fix tests

* PR fixes

* changing protocol liquidation fee to be denominated in deca bps

* support max borrows/withdraws (solana-labs#148)

* support max withdraw and borrow

* changing function signature of a test helper fn

* tests for borrow/withdraw max on rate limiter

* rebase fixes

* PR fixes

* rate limiter test fixes + fmt

* audit fixes (solana-labs#154)

* audit fixes

* add test for refresh obligation filtering

* moar audit fixes

* break borrow weight tiebreaks by reserve pubkey, not mint (solana-labs#158)

* fix version numbers, add name to library (solana-labs#159)

* cli changes (solana-labs#155)

* cli changes

* cli fixes + adding subcommands to view accounts

* clippy fixes

* fix CI error

---------

Co-authored-by: nope <83512286+nope-finance@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackcmay jackcmay jackcmay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do.sh build all doesn't strip .so files
2 participants
@CriesofCarrots @jackcmay