token-cli: Transfer to tokenId using spl-token cli should provide more warnings

[achamely]

Currently when using the spl-token transfer command and the --fund-recipient flag it is possible to provide the tokenID as a destination address which results in the creation of an account owned by the tokenId itself.

While I can understand the desire for a very modular/configurable system this type of action is very prone to causing loss to most inexperienced users. I would suggest some additional warnings/feedback or even an additional flag be required when the destination address provided is an actual tokenID to ensure the user knows what they are doing and still really wants to do it.

[joncinque]

As discussed offline, a fix for this could involve failing on transfers where --fund-recipient is provided, but the address is not a wallet / system account. This behavior can be overridden with some other flag that signifies "I'm ok that the owner of this new token account is not a wallet"

[kris524]

Hello, can I pick this issue? Is there any additional info I might need that could help me?

[joncinque]

@kris524 sorry about that, the issue has already been resolved and should have been closed when #3085 was merged. Thanks for reaching out though!