-
Notifications
You must be signed in to change notification settings - Fork 1k
Use RpcRequest in PubSubSubscriptionPlan #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
2dcffdb to
b640c71
Compare
steveluscher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b640c71 to
a363260
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |


This PR changes the configs of the
executeRpcPubSubSubscriptionPlanfunction such that it accepts a "Subscribe Request" as aRpcRequestobject instead of asubscribeMethodNameandsubscribeParamsduo.This mean we can now use the
RpcRequestTransformerprovided in a more idiomatic way.Note: A changeset for this PR is included in #3407.