Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello-world-program.md #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkvallen
Copy link
Contributor

Problem

  • Grammatical mistakes
  • The dependencies and client code needed updates to ensure compatibility with the latest versions and best practices.

Summary of Changes

  • Fixed grammatical mistakes
  • Rephrase some words to make them sound more fluent and easier to read.
  • Added a tutorial video for a visual walkthrough.
  • Updated instructions for installing dependencies and running the client code.
  • Updated dependencies and client code

Fixes #
Unboxed-Software/solana-hello-world-client#6

Problem
- Grammatical mistakes
-  The dependencies and client code needed updates to ensure compatibility with the latest versions and best practices.

Summary of Changes
- Fixed grammatical mistakes
- Rephrase some words to make them sound more fluent and easier to read.
- Added a tutorial video for a visual walkthrough.
- Updated instructions for installing dependencies and running the client code.
- Updated dependencies and client code ( Unboxed-Software/solana-hello-world-client#6 )
@mikemaccana
Copy link
Collaborator

Thanks @darkvallen ! I want to let you know there's another, much larger PR for this lesson that's been submitted by someone else already, however we're very grateful for these changes - I'll review this PR shortly.

@nickfrosty nickfrosty requested review from mikemaccana and removed request for nickfrosty September 11, 2024 13:47
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good changes but also needs some tweaks - see comments below.

Comment on lines +17 to 18
- A program processes an instruction using the **program_id**, a list of
**accounts**, and **instruction_data** included with the instruction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A program processes an instruction using the **program_id**, a list of
**accounts**, and **instruction_data** included with the instruction
- A program processes an instruction using the **program_id**, a set of named
**accounts**, and **instruction_data** included with the instruction

@@ -73,7 +71,7 @@ following structure:

The path to `AccountInfo` would be `solana_program::account_info::AccountInfo`.

Absent of any other keywords, we would need to reference this entire path to use
Absent any other keywords, we would need to reference this entire path to use
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Absent any other keywords, we would need to reference this entire path to use
Without any `use` keywords, we would need to reference this entire path to use

is to build our Solana program, so we’ve gone ahead and provided
[the client code to invoke our “Hello, world!” program](https://github.com/Unboxed-Software/solana-hello-world-client)
for you to download.
In this final step, we'll invoke the "Hello, world!" Solana program from the client side. While the main focus of this lesson is on building your Solana program, we've provided [the client code](https://github.com/Unboxed-Software/solana-hello-world-client) to help you easily interact with your deployed program.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to https://github.com/solana-developers/hello-world-client - can you please make your updates there instead and fix these links?

Comment on lines +340 to +341
![hello-world-solana](https://github.com/user-attachments/assets/6865e275-bbb9-43a1-acf7-8a97438c8ed5)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Video is a good idea. The quality of the video is bad and there seems to be no sound - want to re-record and add a voiceover?

Then contact me via telegram or twitter and send me the raw video for upload to our YouTube channel.

@@ -14,39 +14,39 @@ description: "Use durable nonces to sign transactions ahead of time."
have an expiration date of 150 blocks (~80-90 seconds).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkvallen you also have #450 which is for durable-nonces.md. It makes it very difficult for us to track your work when this happens.

Please put all your changes to durable-nonces.md in that PR and remove it from this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
#450 Ready for further review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants