-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammatic error fix, Comments in code for easy understanding, more explanation on msg macro #417
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this a while ago but forgot to click the button. Please see the comments above! As someone else's changes were merged you will also need to resolve some conflicts.
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
okay I am on it. |
@mikemaccana thank you for making out some time to review this work. please if you have any more changes you would love me to implement, I would be glad to make the fix. I also messaged you on Telegram to find out if we can add more language support to "intro-to-solana". |
Reverted changes on arbitrary-cpi taking it back to normal.
Hello @mikemaccana and @nickfrosty Hope you're both doing great 👍. I have made the necessary adjustments and I also updated arbitrary-cpi.md to it's most recent form to avoid any conflicts. Pls 🙏 merge if it's ok. Thank you and best regards... |
Hello @mikemaccana and @nickfrosty Hope you're both doing great 👍. Updated my Pull request so it's updated and I have only focused on the required file: content/courses/native-onchain-development/hello-world-program.md Please 🙏 help review as to merge. I understand that reviewing may be stressful - I'm grateful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Focused on the reviewed section alone. If there are any other changes you would love me to make, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix but ready to go afrerwards.
content/courses/native-onchain-development/hello-world-program.md
Outdated
Show resolved
Hide resolved
As recommended, I removed the unnecessary code block indicator since it was a markdown file.
@mikemaccana , @nickfrosty please don't forget to include my contribution. Hello Bro 👋 hope you're doing good? I'm sorry for bordering/disturbing you but I just felt it's been a while. Pls help merge this pull request or give me further advise. Thank you very much for your understanding. I'm grateful 🥰 |
Problem
The original lesson/code provided lacked clarity in certain areas, particularly in the explanation of paths and scope, function declarations, the concept of Solana programs, entry point syntax, and error handling. These issues might lead to confusion for readers, especially those new to Rust or Solana programming.
Summary of Changes
Paths and Scope Clarification:
use
statement, highlighting its importance in making code more readable and maintainable by bringing items into scope.Function Declaration Explanation:
Entry Point Code - Syntax and Comments:
msg! Macro and Error Handling:
msg!
macro for logging and introduced basic concepts of error handling within Solana programs.