Update links, content and code block in deserialize custom data frontend course #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khankluan24
force-pushed
the
deserialize-custom-data-frontend
branch
from
6853aac
to
658e1ac
Compare
mikemaccana
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Thnaks @khankluan24 ! Good, but mainly seems to be updating for findProgramAddressSync(). I've left a few questions and comments above. Not there are multiple people competing for this lesson so competition is hot!
| you need a refresher on either of these, have a look at the previous lesson. | ||
| Just as before, we’ll use [Borsh](https://github.com/near/borsh) and | ||
| `@coral-xyz/borsh`. If you need a refresher on either of these, have a look at | ||
| the previous lesson. |
There was a problem hiding this comment.
I saw the Borsh website was down, but it's back up again - https://borsh.io/
| @@ -247,7 +248,7 @@ structured. | |||
| #### 3. Create a method to deserialize data | |||
|
|
|||
| Now that we have the buffer layout set up, let’s create a static method in | |||
| `Movie` called `deserialize` that will take an optional `Buffer` and return a | |||
| `Movie` called `deserialize` that will take an optional `buffer` and return a | |||
There was a problem hiding this comment.
Suggested change
| `Movie` called `deserialize` that will take an optional `buffer` and return a | |
| `Movie` called `deserialize` that will take an optional `Buffer` and return a |
The type in node is Buffer capital B
| @@ -377,7 +378,6 @@ If you get really stumped, feel free to | |||
| As always, get creative with these challenges and take them beyond the | |||
| instructions if you want! | |||
|
|
|||
| <Callout type="success" title="Completed the lab?"> | |||
| Push your code to GitHub and | |||
| Push your code to GitHub and <Callout type="success" title="Completed the lab?"> | |||
| [tell us what you thought of this lesson](https://form.typeform.com/to/IPH0UGz7#answers-lesson=9cb89e09-2c97-4185-93b0-c89f7aca7677)! | |||
| </Callout> | |||
There was a problem hiding this comment.
Re: the images, is the only change adding the ...Sync()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update links, content and code block in deserialize custom data frontend course
Summary of Changes
web3.PublicKey.findProgramAddress -> web3.PublicKey.findProgramAddressSyncdue to deprecation).