many changes #8
Open
many changes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemaccana
reviewed
Feb 1, 2024
| - Functions have been upgraded to many levels with <3 from stacc | ||
| - Allow non-constant constants maybe, with <3 from stacc | ||
| - Allow more constants with <3 from stacc | ||
| - Body-only implementation of Try statements with <3 from stacc |
There was a problem hiding this comment.
So much <3 from stacc. Thanks for this!
mikemaccana
reviewed
Feb 1, 2024
| /*if targets.len() != 1 { | ||
| Err(Error::InvalidConstant) | ||
| } else { | ||
| } else */{ |
There was a problem hiding this comment.
Worth just deleting the dead code, we can get it back from git history if we need it, and the next dev will wonder why it's commented out. This isn't a PR review (I'm new to Rust so not really qualified) just as a general ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has gotten some basic imports to work, in the hopes we can get tf / pytorch to work.
notably, tf now fails on trying to load os.py.
Can we add the contents of the python*.**/lib/*.py libraries to sealang?
check the changelog