Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for supporting typescript #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vip30
Copy link

@vip30 vip30 commented Oct 25, 2018

No description provided.

@vip30 vip30 mentioned this pull request Oct 25, 2018
@gabrielstuff
Copy link
Member

Hello @vip30 what is the advantage for us to include this typescript support ?
Thanks!

@vip30
Copy link
Author

vip30 commented Feb 8, 2019

@gabrielstuff

Here is the advantage of including d.ts

Without the declaration typescript compiler will warn you with
image

and if you are using this syntax

Vue.extend({
  onIdle() {
    this.messageStr = 'ZZZ'
  },
})

compiler will warn you with
image

You can get the typing by using this.isAppIdle
image

and for closing the issue #30

@gabrielstuff
Copy link
Member

hello, no update for a long time. Will take time to review it today. Sorry for this delay.

@lastlink
Copy link

any updates on this?

1 similar comment
@jevillard
Copy link

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants